Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Requesting 'profile' option to be added to the tool #44

Closed
nanthinimuniapan opened this issue May 23, 2023 · 3 comments · Fixed by #55
Closed

Feature request: Requesting 'profile' option to be added to the tool #44

nanthinimuniapan opened this issue May 23, 2023 · 3 comments · Fixed by #55
Labels
feature-request Request for a new feature

Comments

@nanthinimuniapan
Copy link

Use case

Currently eksup takes in cluster name and region information when performing the analysis, it should also consider the profile (from aws config) to perform analysis as well.

Solution/User Experience

eksup analyze --cluster clustername --region regionname --profile awsprofilename

Alternative solutions

When performing eksup analyze if no profile information is provided, it should take in information from KUBECONFIG variable or ~/.kube/config file.
@nanthinimuniapan nanthinimuniapan added feature-request Request for a new feature triage labels May 23, 2023
@dennmee
Copy link

dennmee commented May 23, 2023

Adding to this, it should take into account the AWS_POFILE env var if set and prompt for MFA if required. Currently this configuration does not work.

@nanthinimuniapan
Copy link
Author

@dennmee There is an alternative way of setting up MFA with AWS CLI that doesn't require entering MFA serial number on the terminal i.e https://repost.aws/knowledge-center/authenticate-mfa-cli

@bryantbiggs
Copy link
Member

I believe the AWS_PROFILE is respected today - ref https://docs.aws.amazon.com/sdk-for-rust/latest/dg/credentials.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants