Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Proposal: tracing.ServerMiddleware 同时支持 metainfo 和 metadata 协议读取 #1323

Closed
Lansongxx opened this issue Apr 13, 2024 · 2 comments · Fixed by kitex-contrib/obs-opentelemetry#45
Closed

Feature Proposal: tracing.ServerMiddleware 同时支持 metainfo 和 metadata 协议读取 #1323

Lansongxx opened this issue Apr 13, 2024 · 2 comments · Fixed by kitex-contrib/obs-opentelemetry#45

Comments

@Lansongxx
Copy link

Is your feature request related to a problem? Please describe.

当我使用 springboot 时，因为 springboot 按照 grpc 标准的 metadata 协议透传上下文信息，而 kitex 的 ServerMiddleware 只按照metainfo 进行读取，从而导致使用 springboot 时遇到问题

Describe the solution you'd like

添加 metadata的解析方法

Describe alternatives you've considered

当然也可以自己添加拦截器，我觉得可以考虑支持一下

Additional context

图片
@felix021
Copy link
Contributor

felix021 commented Apr 18, 2024 •
edited
Loading

Kitex gRPC metadata
 这里的 metadata.FromIncomingContext 应该可以在 svr mw 里用的

@rogerogers rogerogers mentioned this issue Apr 20, 2024
Merged
@rogerogers
Copy link

@Lansongxx 看下符合需求吗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow retrieving data from metadata or adding data to metadata kitex-contrib/obs-opentelemetry
3 participants
@felix021 @rogerogers @Lansongxx