Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure bindata.go is not shown as "unstaged changes" needlessly #498

Open
vozhyk- opened this issue Jul 19, 2017 · 0 comments
Open

Ensure bindata.go is not shown as "unstaged changes" needlessly #498

vozhyk- opened this issue Jul 19, 2017 · 0 comments

Comments

@vozhyk-
Copy link
Contributor

vozhyk- commented Jul 19, 2017

This is a follow-up for #496.

bindata.go is regenerated on every make and is added to the repository. This makes it appear as "unstaged changes" after the source is built.

There are 2 ways the problem can be fixed:

  • Removing the file from the repository and adding it to .gitignore (bindata.go is a generated file #496). This isn't desirable because it

    will cause 'go get' to fail since there are no post-go-get hooks that can recreate this file.

  • Making the rule that regenerates the file separate from the all rule and making sure the file is regenerated and committed whenever the data changes
    • with a commit hook?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant