Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

troposphere 3.0 #1904

Closed
markpeek opened this issue May 18, 2021 · 10 comments
Closed

troposphere 3.0 #1904

markpeek opened this issue May 18, 2021 · 10 comments

Comments

@markpeek
Copy link
Member

Another issue was tracking troposphere 3.0 changes but was pretty large in scope. Recent changes to deprecate Python 2 support and have a Python 3 only release have been committed. This issue is to track any additional (minimal) changes to get a 3.0 release made.

@michael-k please commend on any changes you think are necessary to proceed. Likely I'll go with a manual release process for this first release.

@workmanw per your request in #1889

@workmanw
Copy link
Contributor

@markpeek Hey thanks! I hope it's not too much work for you. We really appreciate it!

@michael-k
Copy link
Contributor

As I've said in #1558, I think dropping support for Python 2 is enough for a 3.0 release and then do everything else later. 🤷

Doing more major version bumps but with only a few breaking changes at once should be easier to handle for maintainers and users. (As long as they aren't on a daily basis. ;) )

@ITProKyle
Copy link
Contributor

ITProKyle commented Jun 3, 2021

Nothing to delay the release for but a few maintenance/QoL items that could go well alongside a major release.

If these are things that would be considered, I can put in the time to implement them this week/weekend.

@michael-k
Copy link
Contributor

tox.ini needs an update. It still uses basepython = python2.7

@michael-k
Copy link
Contributor

michael-k commented Jun 7, 2021

The release of 3.0 might also be a good opportunity to rename branch master to main.

@LokiLaufeyjarson
Copy link

LokiLaufeyjarson commented Jun 9, 2021

Hmm, and what are we going to do about: MasterUsername, MasterUserPassword, DedicatedMasterType, DedicatedMasterCount, DedicatedMasterEnabled, MasterInstanceGroup, MasterAutoScalingPolicy, KMSMasterKeyID, MasterSecretArn, MasterSecretKmsKeyArn, EmrManagedMasterSecurityGroup(s), MasterInstanceFleet, MasterInstanceGroup, MasterId, MasterUserARN, MasterUserOptions and AdditionalSlaveSecurityGroups, EmrManagedSlaveSecurityGroup, AwsAccountWhitelist, IpRangeWhitelist, SourceVpcWhitelist, WhitelistRules, AwsAccountBlacklist, IpRangeBlacklist, SourceVpcBlacklist ... ?

@michael-k
Copy link
Contributor

michael-k commented Jun 9, 2021

Hmm, and what are we going to do about: MasterUsername, …

Those are the names that CloudFormation uses. I'd say we keep those names for now to maintain 1:1 compatibility with CloudFormation. The idea is to move away from manually managed code towards code generated from the spec. This would be a good opportunity to introduce some kind of mapping (eg. Master ↔ Main/Primary/…).

Renaming branch master to main is a simpler change and doesn't affect end users.

@workmanw
Copy link
Contributor

Shameful bump. Is there anything that can be done to get this moving forward, or to cut a new 2.7.x release? There is functionality in master we've been waiting on for nearly 2.5 months. We have a project that is at a complete stand still waiting on a new release.

@markpeek
Copy link
Member Author

markpeek commented Jul 5, 2021

@workmanw just pushed Release 3.0.0.

@michael-k thank you for the help on getting the Python 3 work done.

Also, the default branch has been changed to main.

@markpeek markpeek closed this as completed Jul 5, 2021
@workmanw
Copy link
Contributor

workmanw commented Jul 5, 2021

Thanks a lot @markpeek and @michael-k!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants