Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SQL() formats for specific AST nodes #233

Open
apstndb opened this issue Dec 19, 2024 · 1 comment
Open

Improve SQL() formats for specific AST nodes #233

apstndb opened this issue Dec 19, 2024 · 1 comment

Comments

@apstndb
Copy link
Contributor

apstndb commented Dec 19, 2024 •
edited
Loading

  • CREATE TABLE
  • CREATE MODEL

Note

We should reference GetDatabaseDdl format.
Impementation would be here.
https://github.com/GoogleCloudPlatform/cloud-spanner-emulator/tree/master/backend/schema/printer
@apstndb apstndb mentioned this issue Dec 19, 2024
Merged
@makenowjust
Copy link
Collaborator

IMO, "pretty print" is richer/more complex mechanism than this issue expects. Please fix the title to such like "Improve SQL() formats for specific AST nodes".

@apstndb apstndb changed the title Default pretty printing for specific nodes. Improve SQL() format for specific nodes. Dec 19, 2024
@apstndb apstndb changed the title Improve SQL() format for specific nodes. Improve SQL() formats for specific AST nodes Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apstndb @makenowjust