fix: Better Error message for error downloading plugin #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
requested review from
maaarcelino and
erezrokah
and removed request for
a team
disq
approved these changes
May 22, 2024
erezrokah
reviewed
May 23, 2024
managedplugin/hub.go
Outdated
| @@ -27,13 +27,13 @@ func getHubClient(logger zerolog.Logger, ops HubDownloadOptions) (*cloudquery_ap | |||
| func isDockerPlugin(ctx context.Context, c *cloudquery_api.ClientWithResponses, ops HubDownloadOptions) (bool, error) { | |||
| p, err := c.GetPluginVersionWithResponse(ctx, ops.PluginTeam, cloudquery_api.PluginKind(ops.PluginKind), ops.PluginName, ops.PluginVersion) | |||
| if err != nil { | |||
| return false, fmt.Errorf("failed to get plugin information: %w", err) | |||
| return false, fmt.Errorf("failed to get %s plugin (name: %s/%s) information: %w", cloudquery_api.PluginKind(ops.PluginKind), ops.PluginTeam, ops.PluginName, err) | |||
There was a problem hiding this comment.
Do we want to add the version too? Maybe failed to get source plugin cloudquery/[email protected]?
erezrokah
approved these changes
May 23, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
May 23, 2024
🤖 I have created a release *beep* *boop* --- ## [1.19.16](v1.19.15...v1.19.16) (2024-05-23) ### Bug Fixes * Better Error message for error downloading plugin ([#323](#323)) ([7f99e76](7f99e76)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables users to better understand which plugin is failing