fix: Handle plugin execute failure case #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
commented
Dec 7, 2023
| var err error | ||
| c.Conn, err = grpc.DialContext(ctx, c.grpcSocketName, | ||
| c.Conn, err = grpc.DialContext(ktx, c.grpcSocketName, |
There was a problem hiding this comment.
from the godoc:
In the blocking case, ctx can be used to cancel or expire the pending connection. Once this function returns, the cancellation and expiration of ctx will be noop.
erezrokah
approved these changes
Dec 7, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
🤖 I have created a release *beep* *boop* --- ## [1.14.3](v1.14.2...v1.14.3) (2023-12-07) ### Bug Fixes * **deps:** Update github.com/gomarkdown/markdown digest to a660076 ([#175](#175)) ([3ee549b](3ee549b)) * **deps:** Update golang.org/x/exp digest to 6522937 ([#176](#176)) ([1f0e032](1f0e032)) * **deps:** Update google.golang.org/genproto/googleapis/rpc digest to 3a041ad ([#178](#178)) ([1e7f21a](1e7f21a)) * **deps:** Update module github.com/avast/retry-go/v4 to v4.5.1 ([#179](#179)) ([3fdb491](3fdb491)) * **deps:** Update module github.com/chenzhuoyu/iasm to v0.9.1 ([#180](#180)) ([e5ee4b5](e5ee4b5)) * **deps:** Update module github.com/gorilla/css to v1.0.1 ([#181](#181)) ([a53c93f](a53c93f)) * **deps:** Update module github.com/kataras/golog to v0.1.11 ([#182](#182)) ([63ebf10](63ebf10)) * **deps:** Update module github.com/kataras/iris/v12 to v12.2.8 ([#183](#183)) ([cd22fa7](cd22fa7)) * Handle plugin execute failure case ([#185](#185)) ([4708734](4708734)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, if the plugin fails to execute it will hang trying to connect to grpc.