Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Added glue crawlers #1363

Merged
merged 7 commits into from
Aug 4, 2022
Merged

feat: Added glue crawlers #1363

merged 7 commits into from
Aug 4, 2022

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented Aug 2, 2022

Summary

closes #1298


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt to format your code πŸ–Š
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here πŸ§ͺ
  • Update the docs by running go run ./docs/docs.go and committing the changes πŸ“ƒ
  • If adding a new resource, add relevant Terraform files in a separate PR πŸ“‚
  • Ensure the status checks below are successful βœ…

@amanenk amanenk marked this pull request as ready for review August 2, 2022 09:29
@amanenk amanenk requested a review from a team as a code owner August 2, 2022 09:29
@amanenk amanenk requested review from irmatov, roneli and hermanschaaf and removed request for a team August 2, 2022 09:29
@hermanschaaf
Copy link
Member

@amanenk looks like the branch has a couple of merge conflicts, would you mind resolving those? πŸ™‡

amanenk added 2 commits August 3, 2022 15:43
# Conflicts:
#	client/mocks/glue.go
#	client/services.go
#	resources/provider/provider.go
Copy link
Member

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question, but otherwise LGTM!

go.mod Outdated Show resolved Hide resolved
@amanenk amanenk requested a review from hermanschaaf August 4, 2022 08:22
@amanenk amanenk merged commit 177e690 into cloudquery:main Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS::Glue::Crawler
2 participants