Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Implement Glue registries resource #1334

Merged
merged 11 commits into from
Aug 8, 2022
Merged

feat: Implement Glue registries resource #1334

merged 11 commits into from
Aug 8, 2022

Conversation

irmatov
Copy link
Contributor

@irmatov irmatov commented Jul 28, 2022

Closes #1324

@irmatov irmatov marked this pull request as ready for review July 29, 2022 10:52
@irmatov irmatov requested a review from a team as a code owner July 29, 2022 10:52
@irmatov irmatov requested review from shimonp21 and amanenk and removed request for a team July 29, 2022 10:52
amanenk
amanenk approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@amanenk amanenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. the code can be standardized a bit.

resources/services/glue/registries.go Show resolved Hide resolved
@hermanschaaf
Copy link
Member

@irmatov If you bring this branch up to date with the main branch, the integration tests should no longer be a requirement and I'd expect the build to pass.

amanenk added 7 commits August 3, 2022 14:20
@amanenk
Merge remote-tracking branch 'upstream/main' into feat/glue_registries
7edf3d0 
# Conflicts:
#	client/mocks/glue.go
#	resources/provider/provider.go
@amanenk
fix
0d7c5f1
@amanenk
added schema versions
49fd256 
added version metadata
@amanenk
docs
dd068f0
@amanenk
Merge remote-tracking branch 'upstream/main' into feat/glue_registries
3c81dca 
# Conflicts:
#	client/mocks/glue.go
#	client/services.go
#	resources/provider/provider.go
@amanenk
mock
33b6d2c
@amanenk
fix
027f992
@amanenk amanenk requested a review from hermanschaaf August 4, 2022 10:06
@amanenk amanenk requested a review from hermanschaaf August 4, 2022 10:36
candiduslynx
candiduslynx suggested changes Aug 4, 2022
View reviewed changes
docs/tables/aws_glue_registry_schema_versions.md Outdated Show resolved Hide resolved
docs/tables/aws_glue_registry_schemas.md Outdated Show resolved Hide resolved
@amanenk amanenk requested a review from candiduslynx August 4, 2022 15:45
@irmatov irmatov merged commit 5e20e88 into cloudquery:main Aug 8, 2022
@irmatov irmatov deleted the feat/glue_registries branch August 8, 2022 08:14
@cq-bot cq-bot mentioned this pull request Aug 8, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amanenk amanenk amanenk approved these changes

@bbernays bbernays bbernays approved these changes

@candiduslynx candiduslynx candiduslynx approved these changes

@hermanschaaf hermanschaaf hermanschaaf approved these changes

@shimonp21 shimonp21 Awaiting requested review from shimonp21 shimonp21 is a code owner automatically assigned from cloudquery/cloudquery-opensource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS::Glue::Registry resource
5 participants
@irmatov @hermanschaaf @candiduslynx @amanenk @bbernays