Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Implement Glue Triggers resource #1322

Merged
merged 4 commits into from
Aug 3, 2022
Merged

feat: Implement Glue Triggers resource #1322

merged 4 commits into from
Aug 3, 2022

Conversation

irmatov
Copy link
Contributor

@irmatov irmatov commented Jul 28, 2022 •
edited
Loading

Closes #1311

@irmatov irmatov requested a review from amanenk July 28, 2022 11:37
@irmatov irmatov marked this pull request as ready for review July 29, 2022 13:24
@irmatov irmatov requested a review from a team as a code owner July 29, 2022 13:24
amanenk
amanenk suggested changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@amanenk amanenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Some description need to be fixed

resources/services/glue/triggers.go Outdated Show resolved Hide resolved
resources/services/glue/triggers.go Outdated Show resolved Hide resolved
@amanenk amanenk self-requested a review August 3, 2022 11:21
@amanenk amanenk merged commit 8261048 into cloudquery:main Aug 3, 2022
@cq-bot cq-bot mentioned this pull request Aug 3, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amanenk amanenk amanenk approved these changes

@hermanschaaf hermanschaaf hermanschaaf approved these changes

@roneli roneli Awaiting requested review from roneli

@candiduslynx candiduslynx Awaiting requested review from candiduslynx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS::Glue::Trigger resource
3 participants
@irmatov @hermanschaaf @amanenk