Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Add CloudWatch Logs Log Group Resource #1317

Merged
merged 9 commits into from
Aug 4, 2022
Merged

feat: Add CloudWatch Logs Log Group Resource #1317

merged 9 commits into from
Aug 4, 2022

Conversation

deep-spaced
Copy link
Contributor

@deep-spaced deep-spaced commented Jul 27, 2022 •
edited
Loading

Summary

Adds CloudWatch Logs Log Group support.

Addresses #1296, #1306, and #1307.

CloudWatch Logs Log Stream support is included but commented out due to the potentially massive slowdown when pulling log stream info for a running application.

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@deep-spaced deep-spaced requested a review from a team as a code owner July 27, 2022 20:53
@deep-spaced deep-spaced requested review from yevgenypats and removed request for a team July 27, 2022 20:53
@deep-spaced deep-spaced changed the title Cloudwatch Log Support CloudWatch Logs Log Group Support Jul 27, 2022
@deep-spaced deep-spaced changed the title CloudWatch Logs Log Group Support feat: Add CloudWatch Logs Log Group Resource Jul 27, 2022
@deep-spaced deep-spaced mentioned this pull request Jul 28, 2022
Closed
2 tasks
@bbernays bbernays linked an issue Jul 29, 2022 that may be closed by this pull request
AWS::Logs::LogGroup #1306
Closed
@bbernays bbernays requested a review from candiduslynx August 1, 2022 13:02
candiduslynx
candiduslynx suggested changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@candiduslynx candiduslynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thank you for the PR.
I've marked a few bits that require changes, please address them.

docs/tables/aws_cloudwatchlogs_log_groups.md Outdated Show resolved Hide resolved
resources/services/cloudwatchlogs/gen.hcl Show resolved Hide resolved
resources/services/cloudwatchlogs/log_groups.go Show resolved Hide resolved
bbernays
bbernays reviewed Aug 2, 2022
View reviewed changes
client/services.go Outdated Show resolved Hide resolved
@candiduslynx candiduslynx merged commit 5ae109e into cloudquery:main Aug 4, 2022
@cq-bot cq-bot mentioned this pull request Aug 4, 2022
Merged
@deep-spaced
Copy link
Contributor Author

Thank you all for your help with this!!

@deep-spaced deep-spaced deleted the cloudwatch_logs branch August 4, 2022 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hermanschaaf hermanschaaf hermanschaaf left review comments

@bbernays bbernays bbernays approved these changes

@candiduslynx candiduslynx candiduslynx approved these changes

@yevgenypats yevgenypats Awaiting requested review from yevgenypats yevgenypats is a code owner automatically assigned from cloudquery/cloudquery-opensource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS::Logs::LogGroup
4 participants
@deep-spaced @hermanschaaf @candiduslynx @bbernays