-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove provider config #49
Conversation
/test all |
Please update the tests |
- Remove `requester_aws_assume_role_arn` - Remove `requester_region`
…rm-aws-vpc-peering-multi-account into remove-provider-config
I've addressed the errors that were reported in the tests (ie removing now defunct variables). |
/test all |
@heathsnow see https://www.terraform.io/docs/language/modules/develop/providers.html#passing-providers-explicitly
|
aws.accepter = aws.accepter | ||
aws.requester = aws.requester |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Showing how to set these providers above would be helpful for copying and pasting the example.
/test all |
This pull request is now in conflict. Could you fix it @heathsnow? 🙏 |
I'm closing this draft. No time right now to attend to it. |
Closing, won't fix. |
what
0.15.0
(usingconfiguration_aliases
wasn't working with0.14.x
)why
for_each
andcount
functionality cannot be used with the module which greatly reduces it's utility.references