Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "argument syntax" to remove inline rules #57

Open
Nuru opened this issue Mar 22, 2024 · 0 comments
Open

Use "argument syntax" to remove inline rules #57

Nuru opened this issue Mar 22, 2024 · 0 comments

Comments

@Nuru
Copy link
Contributor

Nuru commented Mar 22, 2024

Describe the Feature

There has been a long-standing issue with aws_security_group that dynamic inline rules could not be removed. This has been fixed in v5.8.0 of the AWS Terraform provider, but needs an implementation change in this module to be effective.

Although inline rules are deprecated in general, the implementation change is easy enough that we should do it.

Expected Behavior

When supplying inline rules in one deployment and then removing all the inline rules in the next deployment, the inline rules should be removed.

Use Case

Migrating inline rules to the newer, recommended separate security group rule resources, is only possible if the inline rules can be removed. Currently, as implemented in this module, the inline rules cannot be removed.

Describe Ideal Solution

Use Arbitrary Expressions with Argument Syntax instead of dynamic blocks to manage the inline rules, so that providing an empty list removes the rules.

Alternatives Considered

No response

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant