Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove --cluster-cidr from kube-router options #137

Closed
murali-reddy opened this issue Aug 25, 2017 · 1 comment
Closed

remove --cluster-cidr from kube-router options #137

murali-reddy opened this issue Aug 25, 2017 · 1 comment
Labels
bug help wanted
Milestone
v0.3.0

Comments

@murali-reddy
Copy link
Member

murali-reddy commented Aug 25, 2017 •
edited
Loading

We fixed Kube-router #107 to make --cluster-cidr optional, and implicitly figure out the CIDR used for pods. We made it optional instead of removing totally so that KOPS which has hard coded manifest embedded with in will not fail.

I fixed KOPS not to use --cluster-cidr with PR kubernetes/kops#3263

However old version of kops will still fail, so we need to keep the flag optional for some time (atleast one two release of kops)

Opening placeholder bug for pending work to remove the flag tottally.
@dimm0 dimm0 mentioned this issue Mar 13, 2018
Closed
@roffe roffe added this to the v0.3.0 milestone Nov 23, 2018
@roffe roffe assigned roffe and unassigned roffe Nov 23, 2018
@murali-reddy murali-reddy mentioned this issue Jul 31, 2020
Merged
@murali-reddy
Copy link
Member Author

Addressed by #961

@aauren aauren closed this as completed Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
3 participants
@aauren @murali-reddy @roffe