Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: scan operator image using Dockle and Snyk #3300

Merged
merged 3 commits into from
Nov 14, 2023
Merged

chore: scan operator image using Dockle and Snyk #3300

merged 3 commits into from
Nov 14, 2023

Conversation

sxd
Copy link
Member

@sxd sxd commented Nov 4, 2023

Closes #3299

Copy link
Contributor

github-actions bot commented Nov 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 release-1.20 release-1.21 labels Nov 4, 2023
Copy link
Contributor

github-actions bot commented Nov 4, 2023

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

Copy link
Contributor

github-actions bot commented Nov 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

github-actions bot commented Nov 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

github-actions bot commented Nov 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@sxd sxd removed the release-1.19 label Nov 4, 2023
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
with:
image: ${{ steps.docker-meta.outputs.tags }}
args: --severity-threshold=high --file=${{ matrix.file }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the --file is not needed here as we scan against docker image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed but need a specific Dockerfile name as we in next step upload the result

Signed-off-by: Tao Li <[email protected]>
@litaocdl
Copy link
Collaborator

/ok-to-merge

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Nov 14, 2023
@litaocdl litaocdl merged commit df095ef into main Nov 14, 2023
29 of 31 checks passed
@litaocdl litaocdl deleted the dev/3299 branch November 14, 2023 10:33
cnpg-bot pushed a commit that referenced this pull request Nov 14, 2023
Closes #3299

Signed-off-by: Jonathan Gonzalez V <[email protected]>
Signed-off-by: Tao Li <[email protected]>
Co-authored-by: Tao Li <[email protected]>
(cherry picked from commit df095ef)
litaocdl added a commit that referenced this pull request Nov 14, 2023
Closes #3299

Signed-off-by: Jonathan Gonzalez V <[email protected]>
Signed-off-by: Tao Li <[email protected]>
Co-authored-by: Tao Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged release-1.20 release-1.21
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Check operator image using Dockle and Snyk
5 participants