Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PostgresConfiguration fields pg_ident and pg_hba to cluster.yaml #342

Closed
nealcm opened this issue Jul 30, 2024 · 5 comments · Fixed by #377
Closed

Add PostgresConfiguration fields pg_ident and pg_hba to cluster.yaml #342

nealcm opened this issue Jul 30, 2024 · 5 comments · Fixed by #377
Labels
chart( cluster ) Related to the cluster chart

Comments

@nealcm
Copy link
Contributor

nealcm commented Jul 30, 2024

Currently the cluster.yaml doesn't have several of the PostgresConfiguration fields exposed, even though they're available in the operator code.

https://cloudnative-pg.io/documentation/current/cloudnative-pg.v1/#postgresql-cnpg-io-v1-PostgresConfiguration

It was added in November, but hasn't been exposed to be overridden in the charts:
https://github.com/cloudnative-pg/cloudnative-pg/pull/3534/files#diff-f9048fd2dc7c8ebfb52c2c4156549537ce2a57009e3ffa2e852d28dda9015ebdR2809

pg_hba and pg_ident are supposed to be exposed here, but the cluster.yaml has to be entirely overridden to use them:

https://github.com/cloudnative-pg/charts/blob/main/charts/cluster/templates/cluster.yaml#L54

Suggest adding templating to look at the values.yaml below the parameters.

  postgresql:
    shared_preload_libraries:
      {{- if eq .Values.type "timescaledb" }}
      - timescaledb
      {{- end }}
    {{- with .Values.cluster.postgresql }}
    parameters:
      {{- toYaml . | nindent 6 }}
    {{- end }}
    {{- with .Values.cluster.pg_ident }}
    pg_ident:
      {{- toYaml . | nindent 6 }}
    {{- end }}
    {{- with .Values.cluster.pg_hba }}
    pg_hba:
      {{- toYaml . | nindent 6 }}
    {{- end }}
@nealcm
Copy link
Contributor Author

nealcm commented Jul 30, 2024

#343

@Stevenpc3
Copy link
Contributor

The MR was closed as a larger solution will be created #343 (comment)

Is there any ETA on this?

@itay-grudev itay-grudev added the chart( cluster ) Related to the cluster chart label Aug 28, 2024
@itay-grudev
Copy link
Collaborator

itay-grudev commented Sep 4, 2024

@Stevenpc3 I just merged #321 which adds pg_hba. It's on main but not yet released. I plan to release it along with several other breaking changes.

Would you mind creating a PR that adds pg_ident and shared_preload_libraries?

@Stevenpc3
Copy link
Contributor

yes we can add that. Thanks for the update 😄

@Stevenpc3
Copy link
Contributor

#377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart( cluster ) Related to the cluster chart
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants