Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing maximum concurrent connections for storage #695

Merged
merged 1 commit into from
May 20, 2022

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented May 20, 2022

This needs to be enforced to 1 for our in-memory database, otherwise no such table errors are creeping up. See mattn/go-sqlite3#511 for more details.

This needs to be enforced to one for our in memory database, otherwise `no such table` errors are creeping up. See mattn/go-sqlite3#511 for more details.
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #695 (e7ad951) into main (2b658cc) will decrease coverage by 0.09%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   81.58%   81.48%   -0.10%     
==========================================
  Files          65       65              
  Lines        6032     6072      +40     
==========================================
+ Hits         4921     4948      +27     
- Misses        856      865       +9     
- Partials      255      259       +4     
Flag Coverage Δ
unittests 81.48% <72.72%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
persistence/gorm/gorm.go 92.13% <70.00%> (-2.81%) ⬇️
persistence/inmemory/inmemory.go 100.00% <100.00%> (ø)
service/discovery/azure/azure.go 79.22% <0.00%> (-5.20%) ⬇️
api/evidence/evidence.go 70.00% <0.00%> (-1.88%) ⬇️
service/assessment/assessment.go 83.37% <0.00%> (-0.28%) ⬇️
policies/rego.go 70.38% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b658cc...e7ad951. Read the comment docs.

@oxisto oxisto merged commit 275f86e into main May 20, 2022
@oxisto oxisto deleted the fix-sqlite-inmemory branch May 20, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant