-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No support for Laravel >=9.x: Is the package still maintained? #116
Comments
Hey @newtonjob, I'm new to the project and have been tasked with bringing this up to date and fixing some bugs and adding new features. I apologize in advance if things look unmaintained as I ramp up and get familiar with the codebase! |
Appreciate your response @joshmanders ❤️ |
yes, it would be great to bring this package live again because we are switching to Cloudinary very soon |
we should be cutting a compatibility release for v9 hopefully early this week and a v10+ release soon after! |
I've cut a 1.0.6 release that makes it work with Laravel v9 again, this week I will be working on bringing it back to working state with bug fixes and tests to ensure no regressions including compatibility with Laravel 10 and 11. |
@DmitrySidorenkoShim can you run |
here you go:
|
to be honest, it is not so important to have it working with Laravel 9.x right now but crucial to have it working with Laravel 10.x as soon as possible and please let me know if I can help in any way 🤔 |
@DmitrySidorenkoShim, if it works for Laravel 9.x, it believe it will also work for 10.x and 11.x Primary issue is that these Laravel versions now use |
This is the issue, and I'm working on it @DmitrySidorenkoShim. See #123 |
hi @joshmanders sorry for annoying you |
Not annoying at all. Working through some stuff now and will hopefully have a release this weekend, Monday at the latest. |
hi @joshmanders I am just wondering if it isn’t ready yet? 😄 |
@DmitrySidorenkoShim I published v2.2.0 yesterday which should make it work in Laravel 10 and 11. Go ahead and give it a try and if you see any problems, please open a new issue so I can address it. |
Huge thanks for your work on this @joshmanders! |
Been using this package for a long time, until I realized all my projects are suddenly breaking.
The package can no longer be used from Laravel >= 9.x which uses
league/flysystem
v3league/flysystem
has since moved to v3, but thisCloudinaryAdapter
still uses interfaces and traits from v1.There are several other issues faced by other devs coming down to same problem, e.g.
I am willing to make PRs to update and generally improve the package, but need to know if we still got some eyes here?
The text was updated successfully, but these errors were encountered: