Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable instance identity via environment flag #552

Closed
x6j8x opened this issue Feb 14, 2018 · 1 comment
Closed

Allow to disable instance identity via environment flag #552

x6j8x opened this issue Feb 14, 2018 · 1 comment
Assignees
Milestone

Comments

@x6j8x
Copy link

x6j8x commented Feb 14, 2018

When diego instance identities are enabled, Java buildpack automatically creates an identity keystore.

This can lead to unwanted complications in apps on an existing CF installation where this happens during a cf-deployment update.

Please introduce an environment flag that disables the creation of the instance identity keystore to enable app level control over this feature.

@nebhale nebhale self-assigned this Feb 14, 2018
@nebhale nebhale added this to the v4.9 milestone Feb 14, 2018
@x6j8x
Copy link
Author

x6j8x commented Feb 15, 2018

@nebhale If I understand the patch correctly, this feature completely disables the security provider and not just the identity keystore. Is this correct?

If yes, than this is more then I asked for. The TrustManager mechanism should stay enabled.

@nebhale nebhale reopened this Feb 15, 2018
nebhale added a commit to cloudfoundry/java-buildpack-security-provider that referenced this issue Feb 15, 2018
Previously, the addition of the SecurityProvider to an application meant that
you always got both the KeyManager and TrustManager for in that application
(although if certain artifacts were missing, these might be no ops).  There
are certain circumstances where you might want one or the other of the
managers though, so being able to disable them individually is useful.  This
change adds an inspection of the org.cloudfoundry.security.keymanager.enabled
and org.cloudfoundry.security.trustmanager.enabled properties to determine if
they should be disabled.  These properties default to true if unspecified.

[cloudfoundry/java-buildpack#552]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants