From a7ed0dccd9f7f4a65111a4bdcbc0b2b2fec9f817 Mon Sep 17 00:00:00 2001 From: Amelia Downs Date: Thu, 18 Apr 2024 14:45:26 -0400 Subject: [PATCH] Check for all types of errors when fetchingTasks to prevent panics (#95) --- db/sqldb/task_db.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/db/sqldb/task_db.go b/db/sqldb/task_db.go index 2ad40edc..5f5ab54f 100644 --- a/db/sqldb/task_db.go +++ b/db/sqldb/task_db.go @@ -458,13 +458,18 @@ func (db *SQLDB) fetchTasks(ctx context.Context, logger lager.Logger, rows *sql. var guid string task, guid, err = db.fetchTaskInternal(logger, rows) - if err == models.ErrDeserialize { - invalidGuids = append(invalidGuids, guid) + if err != nil { + if err == models.ErrDeserialize { + invalidGuids = append(invalidGuids, guid) + } + if abortOnError { break } + continue } + tasks = append(tasks, task) validGuids = append(validGuids, task.TaskGuid) }