-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(publicApi): Allow CRUD Operations for Custom Metrics Strategy via Public APIs #3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalan316
force-pushed
the
public-api-consistent
branch
18 times, most recently
from
November 20, 2024 17:13
3fa7f3d
to
60a141f
Compare
asalan316
force-pushed
the
public-api-consistent
branch
8 times, most recently
from
November 27, 2024 11:51
3ad25bf
to
c060d38
Compare
asalan316
added
the
allow-acceptance-tests
This label needs to be added to enable the acceptance tests to run.
label
Nov 27, 2024
asalan316
force-pushed
the
public-api-consistent
branch
3 times, most recently
from
November 28, 2024 08:09
234c376
to
44af620
Compare
asalan316
force-pushed
the
public-api-consistent
branch
6 times, most recently
from
November 28, 2024 14:30
351b1ce
to
b5e7fa7
Compare
asalan316
changed the title
Public api consistent
feat(publicApi): Allow CRUD Operations for Custom Metrics Strategy via Public APIs
Nov 28, 2024
asalan316
force-pushed
the
public-api-consistent
branch
2 times, most recently
from
November 29, 2024 09:13
e658fb4
to
88412a7
Compare
DeletePolicy custom metrics strategy
asalan316
force-pushed
the
public-api-consistent
branch
3 times, most recently
from
November 29, 2024 09:18
dcf098e
to
c702eab
Compare
GetScalingPolicy => with refactor update custom metrics for mysql
document openapi spec about binding configuration simplify, clean, refactor
asalan316
force-pushed
the
public-api-consistent
branch
from
November 29, 2024 09:29
c702eab
to
59b70ae
Compare
asalan316
force-pushed
the
public-api-consistent
branch
from
December 2, 2024 15:10
59b70ae
to
3fc59be
Compare
bonzofenix
reviewed
Dec 3, 2024
asalan316
force-pushed
the
public-api-consistent
branch
from
December 3, 2024 16:54
f1324b2
to
af3d2aa
Compare
Quality Gate failedFailed conditions |
lgtm |
bonzofenix
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
allow-acceptance-tests
This label needs to be added to enable the acceptance tests to run.
enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, setting custom metrics strategy scenario #2 was only possible via service instance binding process.
This PR allows custom metrics strategy to be updated/retrieved and deleted using existing policy api
https://<server>/v1/apps/:appGuid/policy
provided by the public api serverChanges