Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publicApi): Allow CRUD Operations for Custom Metrics Strategy via Public APIs #3317

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

asalan316
Copy link
Contributor

@asalan316 asalan316 commented Nov 8, 2024

Currently, setting custom metrics strategy scenario #2 was only possible via service instance binding process.

This PR allows custom metrics strategy to be updated/retrieved and deleted using existing policy api https://<server>/v1/apps/:appGuid/policy provided by the public api server

Changes

  • Adjusted GET | PUT | DELETE endpoints
  • Updated open api specifications to reflect the custom metrics strategy
  • Added public api endpoints collection to help in api testing

@asalan316 asalan316 force-pushed the public-api-consistent branch 18 times, most recently from 3fa7f3d to 60a141f Compare November 20, 2024 17:13
@asalan316 asalan316 force-pushed the public-api-consistent branch 8 times, most recently from 3ad25bf to c060d38 Compare November 27, 2024 11:51
@asalan316 asalan316 added the allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. label Nov 27, 2024
@asalan316 asalan316 force-pushed the public-api-consistent branch 3 times, most recently from 234c376 to 44af620 Compare November 28, 2024 08:09
@asalan316 asalan316 force-pushed the public-api-consistent branch 6 times, most recently from 351b1ce to b5e7fa7 Compare November 28, 2024 14:30
@asalan316 asalan316 changed the title Public api consistent feat(publicApi): Allow CRUD Operations for Custom Metrics Strategy via Public APIs Nov 28, 2024
@asalan316 asalan316 marked this pull request as ready for review November 28, 2024 14:58
@asalan316 asalan316 force-pushed the public-api-consistent branch 2 times, most recently from e658fb4 to 88412a7 Compare November 29, 2024 09:13
DeletePolicy custom metrics strategy
@asalan316 asalan316 force-pushed the public-api-consistent branch 3 times, most recently from dcf098e to c702eab Compare November 29, 2024 09:18
GetScalingPolicy => with refactor
update custom metrics for mysql
document openapi spec about binding configuration
simplify, clean, refactor
@asalan316 asalan316 force-pushed the public-api-consistent branch from c702eab to 59b70ae Compare November 29, 2024 09:29
@asalan316 asalan316 force-pushed the public-api-consistent branch from 59b70ae to 3fc59be Compare December 2, 2024 15:10
Makefile Outdated Show resolved Hide resolved
docs/public-api.restclient Outdated Show resolved Hide resolved
src/autoscaler/models/binding_configs_test.go Outdated Show resolved Hide resolved
@asalan316 asalan316 force-pushed the public-api-consistent branch from f1324b2 to af3d2aa Compare December 3, 2024 16:54
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@bonzofenix
Copy link
Contributor

lgtm

@asalan316 asalan316 merged commit 233a67f into main Dec 4, 2024
33 of 34 checks passed
@asalan316 asalan316 deleted the public-api-consistent branch December 4, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants