From 0155d47095d8c7852923324cdbbc33c531a01237 Mon Sep 17 00:00:00 2001 From: Mario Manno Date: Mon, 2 Sep 2019 15:29:34 +0200 Subject: [PATCH] Remove versioned secret watch from generated_variable_controller This is also not user controlled and cfo will not mutate it. It will create a new versioned secret for every change. --- .../generated_variable_controller.go | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/pkg/kube/controllers/boshdeployment/generated_variable_controller.go b/pkg/kube/controllers/boshdeployment/generated_variable_controller.go index d53e1a48c..00aed1f3d 100644 --- a/pkg/kube/controllers/boshdeployment/generated_variable_controller.go +++ b/pkg/kube/controllers/boshdeployment/generated_variable_controller.go @@ -3,7 +3,6 @@ package boshdeployment import ( "context" "fmt" - "reflect" "strings" "github.com/pkg/errors" @@ -60,21 +59,7 @@ func AddGeneratedVariable(ctx context.Context, config *config.Config, mgr manage }, DeleteFunc: func(e event.DeleteEvent) bool { return false }, GenericFunc: func(e event.GenericEvent) bool { return false }, - UpdateFunc: func(e event.UpdateEvent) bool { - oldSecret := e.ObjectOld.(*corev1.Secret) - newSecret := e.ObjectNew.(*corev1.Secret) - shouldProcessEvent := isManifestWithOps(newSecret.Name) && !reflect.DeepEqual(oldSecret.Data, newSecret.Data) - - if shouldProcessEvent { - ctxlog.NewPredicateEvent(newSecret).Debug( - ctx, e.MetaNew, bdv1.SecretReference, - fmt.Sprintf("Update predicate passed for %s, existing secret with the %s suffix has been updated", - e.MetaNew.GetName(), names.DeploymentSecretTypeManifestWithOps.String()), - ) - } - - return shouldProcessEvent - }, + UpdateFunc: func(e event.UpdateEvent) bool { return false }, } // This is a manifest with ops files secret that has changed.