-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exit dev if build fails on first run #734
Conversation
Because of evanw/esbuild#1037, we can't recover dev if esbuild fails on first run. The workaround is to end the process if it does so, until we have a better fix. Reported in #731
🦋 Changeset detectedLatest commit: 8102d0b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2068802363/npm-package-wrangler-734 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/734/npm-package-wrangler-734 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2068802363/npm-package-wrangler-734 dev path/to/script.js |
Not related to this PR but we currently don't format the error message from esbuild during a rebuild as nicely as we could... After this PR we get the following output when failing first time:
But if we fail during a rebuild we get:
|
Dropped a link to your comment in #377 |
Because of evanw/esbuild#1037, we can't recover dev if esbuild fails on first run. The workaround is to end the process if it does so, until we have a better fix.
Reported in #731