fix: assume a worker is a module worker only if it has a default export
#726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 63887ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2059107060/npm-package-wrangler-726You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/726/npm-package-wrangler-726Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2059107060/npm-package-wrangler-726 dev path/to/script.js |
threepointone
commented
Mar 29, 2022
petebacondarwin
approved these changes
Mar 29, 2022
…port This tweaks the logic that guesses worker formats to check whether a `default` export is defined on an entry point before assuming it's a module worker.
threepointone
force-pushed
the
refine-guess-format
branch
from
78b7333 to
63887ae
Compare
Merged
mrbbot
pushed a commit
that referenced
this pull request
Oct 31, 2023
…726) * expose unsafePreventEviction option for durable object bindings * add tests for unsafePreventEviction * parallelise long test run * check unsafePreventEviction value is same across all bindings to each durable object * fix nit * increase (prevent) eviction test timeouts
mrbbot
pushed a commit
that referenced
this pull request
Nov 1, 2023
…726) * expose unsafePreventEviction option for durable object bindings * add tests for unsafePreventEviction * parallelise long test run * check unsafePreventEviction value is same across all bindings to each durable object * fix nit * increase (prevent) eviction test timeouts
mrbbot
pushed a commit
that referenced
this pull request
Nov 1, 2023
…726) * expose unsafePreventEviction option for durable object bindings * add tests for unsafePreventEviction * parallelise long test run * check unsafePreventEviction value is same across all bindings to each durable object * fix nit * increase (prevent) eviction test timeouts
mrbbot
pushed a commit
that referenced
this pull request
Nov 1, 2023
…726) * expose unsafePreventEviction option for durable object bindings * add tests for unsafePreventEviction * parallelise long test run * check unsafePreventEviction value is same across all bindings to each durable object * fix nit * increase (prevent) eviction test timeouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the logic that guesses worker formats to check whether a
defaultexport is defined on an entry point before assuming it's a module worker.