Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename: worker_namespaces / dispatch_namespaces #1725

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

threepointone
Copy link
Contributor

The Worker-for-Platforms team would like to rename this field to more closely match what it's called internally. This fix does a search+replace on this term. This feature already had an experimental warning, and no one's using it at the moment, so we're not going to add a warning/backward compat for existing customers.

The Worker-for-Platforms team would like to rename this field to more closely match what it's called internally. This fix does a search+replace on this term. This feature already had an experimental warning, and no one's using it at the moment, so we're not going to add a warning/backward compat for existing customers.
@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2022

🦋 Changeset detected

Latest commit: 073941e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2911376289/npm-package-wrangler-1725

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1725/npm-package-wrangler-1725

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2911376289/npm-package-wrangler-1725 dev path/to/script.js

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #1725 (073941e) into main (f638de6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1725      +/-   ##
==========================================
+ Coverage   80.67%   80.69%   +0.01%     
==========================================
  Files          90       90              
  Lines        6117     6117              
  Branches     1576     1576              
==========================================
+ Hits         4935     4936       +1     
+ Misses       1182     1181       -1     
Impacted Files Coverage Δ
packages/wrangler/src/dev.tsx 82.19% <ø> (ø)
packages/wrangler/src/metrics/send-event.ts 100.00% <ø> (ø)
packages/wrangler/src/publish.ts 91.92% <ø> (ø)
packages/wrangler/src/config/index.ts 98.82% <100.00%> (ø)
packages/wrangler/src/config/validation.ts 91.57% <100.00%> (ø)
packages/wrangler/src/create-worker-upload-form.ts 94.25% <100.00%> (ø)
packages/wrangler/src/dispatch-namespace.ts 100.00% <100.00%> (ø)
packages/wrangler/src/index.tsx 89.04% <100.00%> (ø)
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

@threepointone threepointone marked this pull request as ready for review August 23, 2022 14:39
wrangler kv:bulk 💪 Interact with multiple Workers KV key-value pairs at once
wrangler pages ⚡️ Configure Cloudflare Pages
wrangler r2 📦 Interact with an R2 store
wrangler dispatch-namespace 📦 Interact with a dispatch namespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentionally vague?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an experimental feature, so it's not super documented or widely available yet. I suspect this will change a little in the future, so it's fine for now?

@threepointone threepointone merged commit eb75413 into main Aug 23, 2022
@threepointone threepointone deleted the rename-worker-dispatch-namespaces branch August 23, 2022 15:03
@github-actions github-actions bot mentioned this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants