Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-cloudflare): allow users to change prompt answer #6428

Merged
merged 18 commits into from
Aug 15, 2024

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Aug 6, 2024

What this PR solves / how to test

This PRs introduces a "Go back" option to most template related questions so users can go back to the previous question and change the answers.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: No impact to wrangler
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: No changes in behavior.

@edmundhung edmundhung requested review from a team as code owners August 6, 2024 16:30
Copy link

changeset-bot bot commented Aug 6, 2024

🦋 Changeset detected

Latest commit: 33be408

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@edmundhung edmundhung marked this pull request as draft August 6, 2024 16:30
Copy link
Contributor

github-actions bot commented Aug 6, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10402413066/npm-package-wrangler-6428

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6428/npm-package-wrangler-6428

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10402413066/npm-package-wrangler-6428 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10402413066/npm-package-create-cloudflare-6428 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10402413066/npm-package-cloudflare-kv-asset-handler-6428
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10402413066/npm-package-miniflare-6428
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10402413066/npm-package-cloudflare-pages-shared-6428
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10402413066/npm-package-cloudflare-vitest-pool-workers-6428
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10402413066/npm-package-cloudflare-workers-editor-shared-6428
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10402413066/npm-package-cloudflare-workers-shared-6428

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.0
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung force-pushed the edmundhung/c3-back-button branch 2 times, most recently from eef5faa to 5857b5e Compare August 8, 2024 12:06
@edmundhung edmundhung force-pushed the edmundhung/c3-back-button branch 3 times, most recently from b2b2f7f to ddd7fe5 Compare August 8, 2024 16:49
@edmundhung edmundhung force-pushed the edmundhung/c3-back-button branch from 5007b72 to fb74f79 Compare August 12, 2024 11:34
@edmundhung edmundhung marked this pull request as ready for review August 14, 2024 10:16
@edmundhung edmundhung changed the title feat(create-cloudflare): allow users to change some answers feat(create-cloudflare): allow users to change prompt answer Aug 14, 2024
@edmundhung edmundhung merged commit 37dc86f into main Aug 15, 2024
23 checks passed
@edmundhung edmundhung deleted the edmundhung/c3-back-button branch August 15, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants