Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work out why workerd processes aren't shutdown #4637

Closed
mrbbot opened this issue Dec 20, 2023 · 3 comments · Fixed by #7169
Closed

Work out why workerd processes aren't shutdown #4637

mrbbot opened this issue Dec 20, 2023 · 3 comments · Fixed by #7169
Assignees
Labels
start-dev-worker Relating to the startDevWorker API

Comments

@mrbbot
Copy link
Contributor

mrbbot commented Dec 20, 2023

We need to identify the root cause of #4612, fixed by #4635

@flexchar
Copy link

I'm experiencing the same. I added a kill command inside my package.json to get away from it for the time being - maybe it's helpful to others too.

    "scripts": {
        "serve": "wrangler dev src/index.ts || bun run kill",
        "deploy": "wrangler deploy --minify src/index.ts",
        "kill": "lsof -i :8787 | awk 'NR!=1 {print $2}' | xargs kill"
    },

@petebacondarwin petebacondarwin added the start-dev-worker Relating to the startDevWorker API label Feb 22, 2024
@lrapoport-cf lrapoport-cf moved this from Untriaged to Backlog in workers-sdk Mar 5, 2024
@KevSlashNull
Copy link

Some of our engineers and community members are still experiencing #4612 at times. The earliest version of workerd we even used was 1.20240129.0, so #4635 was already released. We’re now on 1.20240806.0.

We haven’t found a reproduction yet unfortunately—just that it happens likely after long or intense use—but I’ll report back once we do.

Our tracking issue is: https://gitlab.com/gitlab-org/gitlab-development-kit/-/issues/2159

@KevSlashNull
Copy link

Update: I found reproduction steps for the lingering processes (but not >90% CPU usage or blocking ports, though it might be the same cause?). I opened #6510 because it seems not necessarily related to workerd and moreso to the workerd process not being cleaned up by Wrangler or Miniflare on error.

In our case, stopping the service that uses wrangler during updates might be a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
start-dev-worker Relating to the startDevWorker API
Projects
Status: Done
5 participants