Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: wrangler doesn't open edge when chrome isn't available #1445

Closed
threepointone opened this issue Jul 11, 2022 · 4 comments · Fixed by #7099
Closed

🐛 BUG: wrangler doesn't open edge when chrome isn't available #1445

threepointone opened this issue Jul 11, 2022 · 4 comments · Fixed by #7099
Labels
blocked Blocked on other work bug Something that isn't working

Comments

@threepointone
Copy link
Contributor

What version of Wrangler are you using?

2.0.16

What operating system are you using?

Mac

Describe the Bug

I have Edge installed. I do not have chrome installed. When I hit d after starting up wrangler dev, the devtools don't open. This is the code that should "work": https://github.com/cloudflare/wrangler2/blob/5b4d5a976a72e65149c883d2dbcb21f2125fc56e/packages/wrangler/src/inspect.ts#L646-L658

@threepointone threepointone added the bug Something that isn't working label Jul 11, 2022
@threepointone threepointone moved this to Untriaged in workers-sdk Jul 11, 2022
@threepointone threepointone moved this from Untriaged to Selected for development in workers-sdk Jul 11, 2022
@caass caass self-assigned this Oct 12, 2022
@caass caass moved this from Selected for Development to In Progress in workers-sdk Oct 12, 2022
@caass
Copy link
Contributor

caass commented Oct 12, 2022

This seems related to sindresorhus/open#272, and has to do with an internal bug with open. I'll see if I can reproduce in a minimal app and fix.

@caass
Copy link
Contributor

caass commented Oct 12, 2022

Created sindresorhus/open#289, hopefully it's a starting point to resolve the issue

@caass caass moved this from In Progress to In Review in workers-sdk Oct 12, 2022
@caass caass added the blocked Blocked on other work label Oct 12, 2022
@caass
Copy link
Contributor

caass commented Nov 29, 2022

After not getting any feedback on sindresorhus/open#289, I'm going to put this back in the backlog

@caass caass moved this from In Review to Backlog in workers-sdk Nov 29, 2022
@caass caass removed their assignment Nov 29, 2022
@lrapoport-cf lrapoport-cf moved this from Backlog to Untriaged in workers-sdk Mar 6, 2023
@1000hz 1000hz moved this from Untriaged to Backlog in workers-sdk Apr 24, 2023
@caass caass removed their assignment May 18, 2023
@lrapoport-cf lrapoport-cf moved this from Backlog to Untriaged in workers-sdk Jul 31, 2023
@lrapoport-cf lrapoport-cf moved this from Untriaged to Other in workers-sdk Aug 14, 2023
@makepanic
Copy link

makepanic commented Mar 3, 2024

One potential workaround for this would be to support an environment variable that allows the user to specify the requested chrome based browser binary, e.g.:

DEVTOOLS_BROWSER=/usr/bin/chromium wrangler pages dev ...

If this would be ok I can open a PR which adds support for it. That way any new browser or currently unsupported browser can be supported without adjusting the code.
I'm seeing a similar issue here on linux. It tries to open google-chrome which isn't installed but chromium is. With an environment variable i could ignore this and tell wrangler to use the chromium binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on other work bug Something that isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants