From d10d5c9e0bfd9d9b35bad160513d2cfcc6bc2c94 Mon Sep 17 00:00:00 2001 From: Cole MacKenzie Date: Fri, 24 Jan 2025 13:04:07 -0800 Subject: [PATCH] remove defaults and rely on API defaults instead --- packages/wrangler/src/__tests__/pipelines.test.ts | 4 ++-- packages/wrangler/src/pipelines/cli/create.ts | 7 +++---- packages/wrangler/src/pipelines/cli/update.ts | 1 - 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/wrangler/src/__tests__/pipelines.test.ts b/packages/wrangler/src/__tests__/pipelines.test.ts index bc1fb57870981..77fed7fe3f096 100644 --- a/packages/wrangler/src/__tests__/pipelines.test.ts +++ b/packages/wrangler/src/__tests__/pipelines.test.ts @@ -304,8 +304,8 @@ describe("pipelines", () => { --r2-secret-access-key R2 service Secret Access Key for authentication. Leave empty for OAuth confirmation. [string] --r2-prefix Prefix for storing files in the destination bucket [string] [default: \\"\\"] --compression Compression format for output files [string] [choices: \\"none\\", \\"gzip\\", \\"deflate\\"] [default: \\"gzip\\"] - --file-template Template for individual file names (must include \${slug}) [string] [default: \\"\${slug}\${extension}\\"] - --partition-template Path template for partitioned files in the bucket [string] [default: \\"event_date=\${date}/hr=\${hr}\\"] + --file-template Template for individual file names (must include \${slug}) [string] + --partition-template Path template for partitioned files in the bucket. If not specified, the default will be used [string] GLOBAL FLAGS -c, --config Path to Wrangler configuration file [string] diff --git a/packages/wrangler/src/pipelines/cli/create.ts b/packages/wrangler/src/pipelines/cli/create.ts index 626ab965cc3e2..63546a666d141 100644 --- a/packages/wrangler/src/pipelines/cli/create.ts +++ b/packages/wrangler/src/pipelines/cli/create.ts @@ -157,16 +157,15 @@ export function addCreateOptions(yargs: Argv) { }) .option("partition-template", { type: "string", - describe: "Path template for partitioned files in the bucket", - default: "event_date=${date}/hr=${hour}", + describe: + "Path template for partitioned files in the bucket. If not specified, the default will be used", demandOption: false, }) .option("file-template", { type: "string", describe: "Template for individual file names (must include ${slug})", - default: "${slug}${extension}", demandOption: false, - coerce: (val: string) => { + coerce: (val) => { if (!val.includes("${slug}")) { throw new Error("filename must contain ${slug}"); } diff --git a/packages/wrangler/src/pipelines/cli/update.ts b/packages/wrangler/src/pipelines/cli/update.ts index 7c48d29550de9..aa192f1eade2c 100644 --- a/packages/wrangler/src/pipelines/cli/update.ts +++ b/packages/wrangler/src/pipelines/cli/update.ts @@ -105,7 +105,6 @@ export function addUpdateOptions(yargs: Argv) { type: "string", describe: "PipelineTransform worker and entrypoint (.)", - default: undefined, demandOption: false, })