Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_ipsec_tunnel: Adds IPsec tunnel health_check_direction & health_check_rate parameters #3112

Conversation

cehrig
Copy link
Contributor

@cehrig cehrig commented Feb 8, 2024

The following PR to cloudflare-go is required before this can be merged:
cloudflare/cloudflare-go#1503

--

This PR adds two new fields to the cloudflare_ipsec_tunnel resource:

  • health_check_direction: one of unidirectional, bidirectional
  • health_check_rate: one of low, mid, high

Additionally an issue with creating IPsec tunnel health checks in the first place has been fixed.

This has been tested against an actual environment & integration tests have been adjusted.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

changelog detected ✅

@cehrig cehrig force-pushed the cehrig/ipsec-healthcheck-direction-and-rate branch from c29a2f0 to 13ade8c Compare February 8, 2024 20:31
@cehrig cehrig force-pushed the cehrig/ipsec-healthcheck-direction-and-rate branch from 13ade8c to faab84c Compare February 8, 2024 20:32
@cehrig cehrig changed the title cloudflare_ipsec_tunnel: Adds IPsec tunnel health_check_direction & health_check_rate parameters resource/cloudflare_ipsec_tunnel: Adds IPsec tunnel health_check_direction & health_check_rate parameters Feb 8, 2024
Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@jacobbednarz jacobbednarz added workflow/pending-contributor-response Indicates an issue or PR requires a response from a contributor. and removed lifecycle/stale labels Mar 13, 2024
@cehrig
Copy link
Contributor Author

cehrig commented Mar 21, 2024

Hey @jacobbednarz anything needed from my end? Looks like we are all green after the cloudflare-go merge.

@jacobbednarz
Copy link
Member

cool! let me run the tests and we can get this merged.

.changelog/3112.txt Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit 097fd4c into cloudflare:master Mar 25, 2024
8 checks passed
@github-actions github-actions bot added this to the v4.28.0 milestone Mar 25, 2024
github-actions bot pushed a commit that referenced this pull request Mar 25, 2024
Copy link
Contributor

This functionality has been released in v4.28.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
workflow/pending-contributor-response Indicates an issue or PR requires a response from a contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants