-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support check_disks
in the device_posture_rule
input block schema
#2280
Support check_disks
in the device_posture_rule
input block schema
#2280
Conversation
changelog detected ✅ |
Ordering isn't important with this value so TypeSet is better suited to avoid permadiffs.
acceptance tests are passing
@aborrello this looks ready to merge. do you have any other changes before i merge it in? |
Nope, everything looks good on my end. Happy for you to merge when ready 🚀 |
thanks for this, you rock 🤘 |
This functionality has been released in v4.2.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Note: This PR is pending the cloudflare/cloudflare-go#1197 enhancement to be released in v0.63.0 of the cloudflare-go library.
Implements the
check_disks
configuration value in theinput
nested schema for thedevice_posture_rule
resource. This value accepts a list of strings, each of which is a discrete volume to check for encryption.This PR additionally splits the
TestAccCloudflareDevicePostureRule_DiskEncryption
test into_RequireAll
and_CheckDisks
.@jacobbednarz an additional PR may be required to remove
Computed
from the schema forrequire_all
as this value is now user-configurable.Related Issues
Closes #1644