Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Cloudflare Queues #2134

Merged
merged 20 commits into from
Feb 3, 2023

Conversation

jbw1991
Copy link
Contributor

@jbw1991 jbw1991 commented Jan 11, 2023

Starting a WIP PR to discuss adding Cloudflare Queues to the terraform provider.

This PR includes:

  • The Queue Resource. The provider can now create/update/delete queues.
  • Queue Bindings for a workers script: A script can bind to a queue by name

Upcoming work:

  • Queue consumer config for a workers script. This is blocked on a "list consumers for script" API endpoint

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2023

changelog detected ✅

@jbw1991
Copy link
Contributor Author

jbw1991 commented Jan 11, 2023

Whoops, forgot that this depends on introducing the "Queue Binding" type to cloudflare-go: cloudflare/cloudflare-go#1176

@jacobbednarz jacobbednarz added workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. and removed workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. labels Jan 11, 2023
@jbw1991
Copy link
Contributor Author

jbw1991 commented Jan 19, 2023

I'll get this back into good shape today

@jbw1991 jbw1991 changed the title WIP: Add support for Cloudflare Queues Add support for Cloudflare Queues Jan 20, 2023
.changelog/2134.txt Outdated Show resolved Hide resolved
@jbw1991
Copy link
Contributor Author

jbw1991 commented Jan 27, 2023

Now blocked on cloudflare/cloudflare-go#1188

@jacobbednarz
Copy link
Member

this all looks fine now but i'm hitting a DSR issue with the Worker bindings acceptance tests. i'll work through this internally but i think we're ok here.

@jacobbednarz jacobbednarz added the workflow/pending-maintainer-response Indicates an issue or PR requires a response from the maintainer team. label Feb 2, 2023
@jacobbednarz jacobbednarz self-assigned this Feb 2, 2023
@jacobbednarz
Copy link
Member

acceptance tests all good!

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^(TestAccCloudflareWorkerScript_|TestAccCloudflareQueue_)" -count 1 -parallel 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareWorkerScript_Import
--- PASS: TestAccCloudflareWorkerScript_Import (15.20s)
=== RUN   TestAccCloudflareQueue_Basic
=== PAUSE TestAccCloudflareQueue_Basic
=== RUN   TestAccCloudflareWorkerScript_MultiScriptEnt
=== PAUSE TestAccCloudflareWorkerScript_MultiScriptEnt
=== RUN   TestAccCloudflareWorkerScript_ModuleUpload
=== PAUSE TestAccCloudflareWorkerScript_ModuleUpload
=== CONT  TestAccCloudflareQueue_Basic
--- PASS: TestAccCloudflareQueue_Basic (19.33s)
=== CONT  TestAccCloudflareWorkerScript_ModuleUpload
--- PASS: TestAccCloudflareWorkerScript_ModuleUpload (10.07s)
=== CONT  TestAccCloudflareWorkerScript_MultiScriptEnt
--- PASS: TestAccCloudflareWorkerScript_MultiScriptEnt (40.30s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	85.218s

@jacobbednarz jacobbednarz merged commit 60b9a16 into cloudflare:master Feb 3, 2023
@github-actions github-actions bot added this to the v3.34.0 milestone Feb 3, 2023
github-actions bot pushed a commit that referenced this pull request Feb 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

This functionality has been released in v3.34.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/pending-maintainer-response Indicates an issue or PR requires a response from the maintainer team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants