Adds support for Pages Projects and Pages Domains #1835

Cyb3r-Jak3 · 2022-08-14T15:14:19Z

Resolves #1037

This PR adds Terraform support for Pages Projects and Pages Domains

Cyb3r-Jak3 · 2022-08-14T15:14:47Z

gitguardian · 2022-08-14T15:14:54Z

⚠️ GitGuardian has uncovered 14 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	`02baa8b`	examples/resources/cloudflare_pages_project/resource.tf	View secret
-	Generic High Entropy Secret	`02baa8b`	examples/resources/cloudflare_pages_project/resource.tf	View secret
-	Generic High Entropy Secret	`02baa8b`	internal/provider/resource_cloudflare_pages_project_test.go	View secret
-	Generic High Entropy Secret	`02baa8b`	internal/provider/resource_cloudflare_pages_project_test.go	View secret
-	Generic High Entropy Secret	`45f2547`	examples/resources/cloudflare_pages_project/resource.tf	View secret
-	Generic High Entropy Secret	`59762b4`	internal/provider/resource_cloudflare_pages_project_test.go	View secret
-	Generic High Entropy Secret	`ea176e6`	examples/resources/cloudflare_pages_project/resource.tf	View secret
-	Generic High Entropy Secret	`ea176e6`	examples/resources/cloudflare_pages_project/resource.tf	View secret
-	Generic High Entropy Secret	`ea176e6`	internal/provider/resource_cloudflare_pages_project_test.go	View secret
-	Generic High Entropy Secret	`f12794e`	internal/provider/resource_cloudflare_pages_project_test.go	View secret
-	Generic High Entropy Secret	`f12794e`	internal/provider/resource_cloudflare_pages_project_test.go	View secret
-	Generic High Entropy Secret	`5eeee91`	examples/resources/cloudflare_pages_project/resource.tf	View secret
-	Generic High Entropy Secret	`5eeee91`	internal/provider/resource_cloudflare_pages_project_test.go	View secret
-	Generic High Entropy Secret	`5eeee91`	internal/provider/resource_cloudflare_pages_project_test.go	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

github-actions · 2022-08-14T15:15:45Z

changelog detected ✅

WalshyDev · 2022-08-14T16:27:48Z

Jake you're the best ❤️

If I can help in any way, let me know :)

Cyb3r-Jak3 · 2022-08-17T23:36:05Z

Will require a version that contains cloudflare/cloudflare-go#1051

…der-cloudflare into pages

WalshyDev · 2022-08-24T16:30:24Z

The failing check is just GitGuardian complaining. Is there anything else needed for this Jake & Jacob? 👀

jacobbednarz · 2022-08-24T19:57:54Z

just time to review and test it out from me.

Cyb3r-Jak3 · 2022-08-24T20:38:31Z

I updated some docs and that new failing test seems to be a golanglint issue and (hopefully) not from something that I introduced.

Cyb3r-Jak3 · 2022-08-27T23:36:46Z

There are two new environment variables needed to test pages, CLOUDFLARE_PAGES_OWNER and CLOUDFLARE_PAGES_REPO. These are used to test source map. This is now pending upstream library as it needs cloudflare/cloudflare-go#1065.

Acceptance Tests pass using the PR branch.

TESTARGS='-run "TestAccTestPages" -count 1 -parallel 1' make testacc
TF_ACC=1 go test $(go list ./...) -v -run "TestAccTestPages" -count 1 -parallel 1 -timeout 120m -parallel 1
?       github.com/cloudflare/terraform-provider-cloudflare     [no test files]
=== RUN   TestAccTestPagesDomain
--- PASS: TestAccTestPagesDomain (7.25s)
=== RUN   TestAccTestPagesProject
--- PASS: TestAccTestPagesProject (9.16s)
=== RUN   TestAccTestPagesProjectBuildConfig
--- PASS: TestAccTestPagesProjectBuildConfig (5.42s)
=== RUN   TestAccTestPagesProjectDeploymentConfig
--- PASS: TestAccTestPagesProjectDeploymentConfig (5.65s)
=== RUN   TestAccTestPagesProjectDirectUpload
--- PASS: TestAccTestPagesProjectDirectUpload (5.49s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/provider   32.976s
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check   [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check        [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check      [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/version     [no test files]

jacobbednarz · 2022-08-29T01:17:20Z

confirmed acceptance tests all green with cloudflare-go shimmed in

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccTestPages" -count 1 -parallel 1 -timeout 120m -parallel 1
?       github.com/cloudflare/terraform-provider-cloudflare     [no test files]
=== RUN   TestAccTestPagesDomain
--- PASS: TestAccTestPagesDomain (13.33s)
=== RUN   TestAccTestPagesProject_Basic
--- PASS: TestAccTestPagesProject_Basic (16.35s)
=== RUN   TestAccTestPagesProject_BuildConfig
--- PASS: TestAccTestPagesProject_BuildConfig (14.76s)
=== RUN   TestAccTestPagesProject_DeploymentConfig
--- PASS: TestAccTestPagesProject_DeploymentConfig (10.76s)
=== RUN   TestAccTestPagesProject_DirectUpload
--- PASS: TestAccTestPagesProject_DirectUpload (12.92s)
=== RUN   TestAccTestPagesProject_PreviewOnly
--- PASS: TestAccTestPagesProject_PreviewOnly (11.12s)
=== RUN   TestAccTestPagesProject_ProductionOnly
--- PASS: TestAccTestPagesProject_ProductionOnly (13.70s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/provider   93.340s
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check   [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check        [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check      [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/version     [no test files]

👍 to merging once the upstream changes land.

itsmechlark · 2022-08-31T09:57:42Z

Any news on this PR? We really need it to migrate all our frontend to Pages.

jacobbednarz · 2022-08-31T21:44:32Z

GitGuardian is all false positives; so ignoring.

WalshyDev · 2022-08-31T21:55:29Z

Whoooo! Thank you very much @Cyb3r-Jak3 and @jacobbednarz !!

You have made a lot of people happy (and lots of internal teams too!) :)

github-actions · 2022-09-07T00:38:56Z

This functionality has been released in v3.23.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Cyb3r-Jak3 added 4 commits August 11, 2022 19:57

Add pages_domain_resource

7dce412

Build out pages project

02baa8b

Split out build config

0e29e37

Add tests for deployment config

3294f5e

Fix PR auto checks

4bd2cf7

Cyb3r-Jak3 added 4 commits August 16, 2022 22:08

Latest Changes

4fabdee

Finish environment variables

d888ab8

Update docs

25bc276

Add compatibility_date and compatibility_flags

45f2547

jacobbednarz added the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Aug 18, 2022

Cyb3r-Jak3 and others added 6 commits August 19, 2022 20:31

Try using a future proof mapping

1177d99

Merge branch 'master' into pages

737b758

Merge branch 'master' into pages

bc2baa7

Remove complex mapping

4ee43df

Merge branch 'pages' of https://github.com/Cyb3r-Jak3/terraform-provi…

327526c

…der-cloudflare into pages

Fix documentation

be81ed3

Cyb3r-Jak3 marked this pull request as ready for review August 22, 2022 02:58

Cyb3r-Jak3 requested a review from jacobbednarz as a code owner August 22, 2022 02:58

Cyb3r-Jak3 and others added 2 commits August 21, 2022 23:08

Fix enviroment variables in example

002b46e

Merge branch 'master' into pages

5725d2a

jacobbednarz removed the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Aug 23, 2022

Update schema descriptions

ccde87c

Update docs

c1460ec

Fix typo

7e9de07

jacobbednarz and others added 4 commits August 25, 2022 10:51

Merge branch 'master' into pages

8e7d2d8

start fixing tests

59762b4

Add example of running subsection of Acceptation tests

7bd914e

Add new pages field to project. Fix all unit tests

ea176e6

Cyb3r-Jak3 force-pushed the pages branch from bbdb7ea to ea176e6 Compare August 27, 2022 23:33

Cyb3r-Jak3 and others added 3 commits August 27, 2022 20:16

Make unit test more readable and add preview/production only ones

f12794e

Merge branch 'master' into pages

ccdfe57

schema cleanup and docs

5eeee91

add workflow env vars

5168fd3

Merge branch 'master' into pages

6466e00

jacobbednarz closed this Aug 31, 2022

jacobbednarz reopened this Aug 31, 2022

jacobbednarz merged commit a396a3f into cloudflare:master Aug 31, 2022

github-actions bot added this to the v3.23.0 milestone Aug 31, 2022

github-actions bot pushed a commit that referenced this pull request Aug 31, 2022

Update CHANGELOG.md for #1835

2d77ca2

Cyb3r-Jak3 deleted the pages branch August 31, 2022 22:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds support for Pages Projects and Pages Domains #1835

Adds support for Pages Projects and Pages Domains #1835

Cyb3r-Jak3 commented Aug 14, 2022 •

edited

Loading

Cyb3r-Jak3 commented Aug 14, 2022

gitguardian bot commented Aug 14, 2022 •

edited

Loading

github-actions bot commented Aug 14, 2022 •

edited

Loading

WalshyDev commented Aug 14, 2022

Cyb3r-Jak3 commented Aug 17, 2022

WalshyDev commented Aug 24, 2022

jacobbednarz commented Aug 24, 2022

Cyb3r-Jak3 commented Aug 24, 2022 •

edited

Loading

Cyb3r-Jak3 commented Aug 27, 2022

jacobbednarz commented Aug 29, 2022

itsmechlark commented Aug 31, 2022

jacobbednarz commented Aug 31, 2022

WalshyDev commented Aug 31, 2022

github-actions bot commented Sep 7, 2022

Adds support for Pages Projects and Pages Domains #1835

Adds support for Pages Projects and Pages Domains #1835

Conversation

Cyb3r-Jak3 commented Aug 14, 2022 • edited Loading

Cyb3r-Jak3 commented Aug 14, 2022

gitguardian bot commented Aug 14, 2022 • edited Loading

⚠️ GitGuardian has uncovered 14 secrets following the scan of your pull request.

github-actions bot commented Aug 14, 2022 • edited Loading

WalshyDev commented Aug 14, 2022

Cyb3r-Jak3 commented Aug 17, 2022

WalshyDev commented Aug 24, 2022

jacobbednarz commented Aug 24, 2022

Cyb3r-Jak3 commented Aug 24, 2022 • edited Loading

Cyb3r-Jak3 commented Aug 27, 2022

jacobbednarz commented Aug 29, 2022

itsmechlark commented Aug 31, 2022

jacobbednarz commented Aug 31, 2022

WalshyDev commented Aug 31, 2022

github-actions bot commented Sep 7, 2022

Cyb3r-Jak3 commented Aug 14, 2022 •

edited

Loading

gitguardian bot commented Aug 14, 2022 •

edited

Loading

github-actions bot commented Aug 14, 2022 •

edited

Loading

Cyb3r-Jak3 commented Aug 24, 2022 •

edited

Loading