resource/access_policy: support importing zone and account level resources #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urces Updates the `Import` to support managing zone and account level policies. Closes #929
|
fyi @Justin-Holmes |
lint rule R001 is good to mitigate "magic" `d.Set` calls however here it is something we need in order to handle both zone + account level imports. Given the current low complexity, I'm onboard with ignoring it for this use case but keeping the check in place for others.
jacobbednarz
deleted the
allow-import-of-zone-and-account-access-policy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
Importto support managing zone and account levelpolicies.
Closes #929