resource/healthcheck: Handle deletion outside of Terraform #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a resource is managed by Terraform, any changes outside of the configuration, should be synced to keep the state in sync. This previously wasn't the case with healthchecks as the 404 error (here, resource has been deleted outside of Terraform) was returning a generic error for any non-success statuses. To fix this, we inspect the returned error and check for a string which denotes the resource not longer exists and then sets `d.Id()` to an empty string and Terraform handles the lifecycle correctly. Fixes cloudflare#785
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
Adds support for Magic Transit IPsec tunnels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a resource is managed by Terraform, any changes outside of the
configuration, should be synced to keep the state in sync. This
previously wasn't the case with healthchecks as the 404 error (here,
resource has been deleted outside of Terraform) was returning a generic
error for any non-success statuses. To fix this, we inspect the returned
error and check for a string which denotes the resource not longer
exists and then sets
d.Id()to an empty string and Terraform handlesthe lifecycle correctly.
Fixes #785