Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TLS certificate packs #778

Merged

Conversation

jacobbednarz
Copy link
Member

@jacobbednarz jacobbednarz commented Aug 26, 2020

Adds coverage for dedicated, custom dedicated and advanced certificate
manager resources.

Screenshot

Depends on cloudflare/cloudflare-go#522 for the CertificatePackAdvancedCertificate.ID field.

@jacobbednarz jacobbednarz force-pushed the certificate-pack-support branch from b53f75d to 47d5406 Compare August 26, 2020 01:06
jacobbednarz added a commit to jacobbednarz/cloudflare-go that referenced this pull request Aug 26, 2020
This wasn't intentionally required however for
cloudflare/terraform-provider-cloudflare#778 to work , this is now.
jacobbednarz added a commit to jacobbednarz/cloudflare-go that referenced this pull request Aug 26, 2020
This wasn't intentionally required however for
cloudflare/terraform-provider-cloudflare#778 to work , this is now.
patryk pushed a commit to cloudflare/cloudflare-go that referenced this pull request Aug 27, 2020
* Add `ID` to `CertificatePackAdvancedCertificate`

This wasn't intentionally required however for
cloudflare/terraform-provider-cloudflare#778 to work , this is now.
@jacobbednarz jacobbednarz force-pushed the certificate-pack-support branch from 47d5406 to de67005 Compare September 2, 2020 02:23
@jacobbednarz jacobbednarz merged commit 2d18860 into cloudflare:master Sep 2, 2020
@jacobbednarz jacobbednarz deleted the certificate-pack-support branch September 2, 2020 02:29
@msmith
Copy link
Contributor

msmith commented Sep 2, 2020

This is great! I was literally just looking to see if this was supported yesterday. 🎉

Justin-Holmes pushed a commit to Justin-Holmes/cloudflare-go that referenced this pull request Sep 17, 2020
* Add `ID` to `CertificatePackAdvancedCertificate`

This wasn't intentionally required however for
cloudflare/terraform-provider-cloudflare#778 to work , this is now.
Justin-Holmes pushed a commit to Justin-Holmes/cloudflare-go that referenced this pull request Sep 18, 2020
* Add `ID` to `CertificatePackAdvancedCertificate`

This wasn't intentionally required however for
cloudflare/terraform-provider-cloudflare#778 to work , this is now.
boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this pull request Feb 28, 2022
…n-parameter-phases

rulesets: add support for ActionParameters.Phases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants