Add auth method group rule type to Access group #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Justin-Holmes
changed the title
Justin-Holmes
force-pushed
the
justin/add-auth-method-rule
branch
from
fdd5342 to
a4f3ce1
Compare
|
@Justin-Holmes I've converted this to a draft PR while we're waiting the upstream changes to be pulled in. |
|
I've pulled in the latest master branch for this one however it looks like it's now getting a struct field error. Would you mind having a dig into it and we can look to get this one merged? |
I forgot to update the field name when I copy/pasted
Justin-Holmes
changed the title
|
This is great, cheers! |
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
…privateappsTF adds private app type and new fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: cloudflare/cloudflare-go#516
Tests will fail until the the cloudflare-go pkg is updated with the above change.