Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access: add support for auto_redirect_to_identity #730

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Access: add support for auto_redirect_to_identity #730

merged 2 commits into from
Jul 13, 2020

Conversation

xens
Copy link
Contributor

@xens xens commented Jul 9, 2020 •
edited
Loading

Goal of this commit is to add support for the auto_redirect_to_identity feature of Cloudflare Access applications. #721

@ghost ghost added the size/XS label Jul 9, 2020
@jacobbednarz
Copy link
Member

This change looks good! We will need to update the associated tests though to ensure we're taking this into account for the existing tests.

@xens
Copy link
Contributor Author

xens commented Jul 9, 2020

Hi @jacobbednarz yes for sure, believe it or not I wasn't able to find them earlier... I'm wondering if I'm missing something but I couldn't find any unittests related to resource_cloudflare_access_application.go .

@jacobbednarz
Copy link
Member

Doesn't look like we have a test file for it in master just yet. #725 introduces it for CORS changes so you're welcome to use that as a starting point and we can resolve the conflicts from there once either one lands if you'd like?

@ghost ghost added size/M kind/documentation Categorizes issue or PR as related to documentation. and removed size/XS labels Jul 10, 2020
@xens
Copy link
Contributor Author

xens commented Jul 10, 2020

Yes make sense, I added the tests and updated the doc at the same time, let me know.

@jacobbednarz
Copy link
Member

You should be good to resolve the conflicts now and we can get this re-reviewed.

@xens
Access: add support for auto_redirect_to_identity
5ccc341 
Goal of this commit is to add support for the `auto_redirect_to_identity`
feature of Cloudflare Access applications.
@xens
Copy link
Contributor Author

xens commented Jul 13, 2020

rebased + fixed conflicts.

@jacobbednarz jacobbednarz merged commit 4f20458 into cloudflare:master Jul 13, 2020
@jacobbednarz
Copy link
Member

Thanking you @xens! 🌟

@jacobbednarz jacobbednarz mentioned this pull request Jul 13, 2020
Closed
boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this pull request Feb 28, 2022
@jacobbednarz
Merge pull request cloudflare#730 from jacobbednarz/rulesets-exposed-…
d0ba80b 
…credential-checks

ruleset: add support for exposed credentials checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xens @jacobbednarz