Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for allowed_idps feature on Cloudflare Access #720

Closed
xens opened this issue Jun 24, 2020 · 5 comments
Closed

Add support for allowed_idps feature on Cloudflare Access #720

xens opened this issue Jun 24, 2020 · 5 comments

Comments

@xens
Copy link
Contributor

xens commented Jun 24, 2020

Goal of this issue is to track the implementation of this missing feature allowed_idps inside the Cloudflare Terraform provider - Access Application resource.

For now this feature is not yet supported inside the cloudflare-go library (WIP -> cloudflare/cloudflare-go#483). When it'll be done we'll be able to work on the Cloudflare Terraform provider implementation.

Ref:

@xens
Copy link
Contributor Author

xens commented Jul 14, 2020

@jacobbednarz I'm not 100% sure how to handle the acceptance tests, ideally I'd create an Access application and specify the IdP UUID into it and then verify that the correct UUID has been set but I don't know if we already have a fake IdP that is defined on our test account that I can reuse ?

@jacobbednarz
Copy link
Member

You can create a dependant resource in your test and reference that. Providing the test exits cleanly, you'll also clean up those resources.

@xens
Copy link
Contributor Author

xens commented Jul 14, 2020

Linked to PR #734

@jacobbednarz
Copy link
Member

Closed in #734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants