resource/cloudflare_argo: Allow settings to be individually customised #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbednarz
force-pushed
the
split-argo-entitlements
branch
from
1e5c8dd to
3f633d6
Compare
There was an assumption in this resource that when you were applying one of the settings, that you would have entitlements to both and you would be explicitly setting both during the resource management. This isn't the case[1] and there are scenarios where someone will manage the `tiered_caching` setting without the entitlement to toggle `smart_routing` to the default value of "off". This splits the two API calls to be individually managed and only applied if there is a value provided for both (customised or default doesn't matter) Fixes cloudflare#701 [1]: terraform-providers/terraform-provider-cloudflare#701
jacobbednarz
force-pushed
the
split-argo-entitlements
branch
from
3f633d6 to
a89e8c4
Compare
ghost
added
size/M
kind/documentation
jacobbednarz
changed the title
patryk
approved these changes
Jun 15, 2020
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
remove feature for deleting Notification PagerDuty destinations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an assumption in this resource that when you were applying one
of the settings, that you would have entitlements to both and you would
be explicitly setting both during the resource management. This isn't
the case and there are scenarios where someone will manage the
tiered_cachingsetting without the entitlement to togglesmart_routingto the default value of "off".This splits the two API calls to be individually managed and only
applied if there is a value provided for both (customised or default
doesn't matter). In this PR, we're also removing the default value for
these two properties to help differentiate whether or not the value
has been defined.
Fixes #701