Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/logpull_retention: Adds new resource #678

Merged

Conversation

jacobbednarz
Copy link
Member

Creates the resource for managing logpull retention flag.

Closes #665

Creates the resource for managing logpull retention flag.

Closes cloudflare#665
@ghost ghost added the size/M label May 7, 2020
When we delete the managed resource, set the flag value to `false` as to
turn off the logpull retention option.
@ghost ghost added size/L kind/documentation Categorizes issue or PR as related to documentation. and removed size/M labels May 7, 2020
@jacobbednarz
Copy link
Member Author

If this is merged before cloudflare/cloudflare-go#452, when the library is updated, these methods will need to be renamed to make the spelling correct as I spelt the method names wrong (consistently though!) in the initial PR.

@jacobbednarz
Copy link
Member Author

Integration is all green now 👍

@jacobbednarz jacobbednarz merged commit 2fe177d into cloudflare:master May 8, 2020
@jacobbednarz jacobbednarz deleted the add-logpull-retention-resource branch May 8, 2020 03:26
boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this pull request Feb 28, 2022
…ack-primary-cert-type

certificate_pack: update `id` and `primary_certificate` types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling log retention (Logpull API)
1 participant