Fix firewall rule products support which was missing handling #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
filipowm
force-pushed
the
bugfix/firewall-products-not-added
branch
from
9a9fc9d to
4192270
Compare
| name := "cloudflare_firewall_rule." + rnd | ||
| zoneID := os.Getenv("CLOUDFLARE_ZONE_ID") | ||
|
|
||
| filterQuoted := `(http.host eq \"` + rnd + `\")` |
There was a problem hiding this comment.
this rule is invalid but i'm unsure why it's not failing when creating it in the tests (as the rule is parsed for validity on creation).
Suggested change
| filterQuoted := `(http.host eq \"` + rnd + `\")` | |
| filterQuoted := `(http.host eq \"terraform.cfapi.net\")` |
(or pull it from the env using CLOUDFLARE_DOMAIN if you'd rather)
There was a problem hiding this comment.
I checked on CF and any string works.
But I've changed it to proposed CLOUDFLARE_DOMAIN,
filipowm
force-pushed
the
bugfix/firewall-products-not-added
branch
from
149a8ee to
e577e87
Compare
jacobbednarz
approved these changes
Mar 23, 2020
|
Thanking you @filipowm 🍰 |
|
Hi, any chance this will be fixed in a new patch release any time soon? We would love to use this feature. |
|
@jacobbednarz Any idea when will be the next release? |
|
We usually release ~ once a month, but it's not a fixed schedule. I'll see about releasing today. |
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
…qual_http_methods_tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource
cloudflare_firewall_rulecontained actionbypassand fieldproducts, however there was no handling implemented what was resulting in error: