Support service_token for cloudflare_access_policy

[dhoeric]

Integrate it since cloudflare/cloudflare-go#339 is already available!

[jacobbednarz]

I've added some notes inline but we will also need to add integration tests for this new functionality before it can land.

I'm on the fence whether we also want to roll in support for "any valid service token" as opposed to just a specific one given that we are already adding for service tokens to be used here.

[dhoeric]

I've added some notes inline but we will also need to add integration tests for this new functionality before it can land.

I'm on the fence whether we also want to roll in support for "any valid service token" as opposed to just a specific one given that we are already adding for service tokens to be used here.

Sure, let me add them as well.

[dhoeric]

If you don't mind to have a discussion, we could have a chat in gitter!

[dhoeric]

Added test for access policy on service_token.

CLOUDFLARE_DOMAIN=xxx CLOUDFLARE_API_KEY=xxx CLOUDFLARE_EMAIL=xxx CLOUDFLARE_ACCOUNT_ID=xxx CLOUDFLARE_ZONE_ID=xxx make testacc TEST=./cloudflare TESTARGS='-run=TestAccAccessPolicy'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./cloudflare -v -run=TestAccAccessPolicy -timeout 120m
=== RUN   TestAccAccessPolicyServiceToken
--- PASS: TestAccAccessPolicyServiceToken (6.32s)
=== RUN   TestAccAccessPolicyAnyServiceToken
--- PASS: TestAccAccessPolicyAnyServiceToken (5.69s)
PASS
ok      github.com/terraform-providers/terraform-provider-cloudflare/cloudflare

[jacobbednarz]

Thanks for working through this one with me @dhoeric! Greatly appreciated ⭐