Apply Single Zone Settings on Delete #599
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The singleZoneSettings, for example h2_prioritization, are not reverted in the Delete function.
The result being if you run terratest (or terraform acceptance tests) you end up with the error:
As h2_prioritization, and the other singleZoneSettings are trying to be applied in the
UpdateZoneSettings
client request, in the delete function. The cloudflare api isn't allowing the single zone settings of h2_prioritization to be set in UpdateZoneSettings, but requires the to be applied inZoneSingleSetting
.This has been catered for in all other methods, but the Delete. The result is it causes issues if we try to run terratest or
TF_ACC=1
, where the zone settings are deleted (reverted) at the end of the tests.The tests have been updated to read in the singleZoneSettings.