Handle errors properly in Logpush resource

[pawelkowalak]

I was unable to create a Logpush resource in Cloudflare and error is not printed out. Here is example apply:

Error: error creating logpush job

  on cloudflare-log-push.tf line 34, in resource "cloudflare_logpush_job" "cloudflare_logpush":
  34: resource "cloudflare_logpush_job" "cloudflare_logpush" {

This is resource I'm trying to create:

// To generate ownership_challenge see: https://developers.cloudflare.com/logs/logpush/logpush-configuration-api/understanding-logpush-api/#ownership
resource "cloudflare_logpush_job" "cloudflare_logpush" {
  count               = var.cloudflare_logpush_challenge == "" ? 0 : 1
  zone_id             = var.cloudflare_zone_id_map[var.environment]
  name                = "Logpush Job for ${var.environment}"
  destination_conf    = "s3://${module.cloudflare_logpush_bucket.name}/{DATE}?region=${var.region}&sse=AES256"
  logpull_options     = "fields=RayID,ClientIP,EdgeStartTimestamp&timestamps=rfc3339"
  ownership_challenge = var.cloudflare_logpush_challenge
}

I've noticed that error creating logpush job log line is swallowing original error, probably from Cloudflare API, so I've created this PR to fill the gaps. Also fixed some other error messages.

[jacobbednarz]

Can you explain what your error ended up being and how this change fixed it? Right now I’m not sure how this has fixed any issues.

Using TF_LOG=DEBUG is also useful to track down where terraform is falling over.

[LeMyst]

Hello,
I come here because I've issue with Logpush Job and terraform.
I don't know if @pawelkowalak have managed to create a logpush ressource, but I don't think the cloudflare_logpush_job can work in state.

There is a missing part in the cloudflare_logpush_job resource: you can't validate the challenge.

I think the easiest way to do that, is to call "GetLogpushOwnershipChallenge" when there is no challenge provided (and so, make the challenge non required), and when you update the ressource with the challenge, call the "ValidateLogpushOwnershipChallenge".

[pawelkowalak]

Hi @Mystou, I didn't have time to debug it more or even check what error is hidden. We've created Logpush manually for now. We'll get back to this at some point probably. I'll update this PR according to @jacobbednarz comments.

[jacobbednarz]

Thanks for this @pawelkowalak 🎉 !