zone_settings_overrid: Remap 0rtt attribute name to zero_rtt #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XS
kind/documentation
sean-
referenced
this pull request
in sean-/cf-terraforming
Dec 11, 2019
|
Thanks @sean- and @jacobbednarz. I got some signals about this issue internally, but had no time to fix it. |
`0rtt` is not a valid HCL attribute name (the scanner begins to process this as a digit, not a string). Fixes: cloudflare#555
|
@patryk Done. Ball's in your court. |
|
Thanks for this @sean-, appreciate it! 🤜 🤛 |
|
Thanks, looking forward to the 2.2.1 release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0rttis not a valid HCL attribute name (the scanner begins to process this asa digit, not a string). See my comment in #542 for details.
Fixes: #555