Support allowed modes for WAF Rules #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing an issue when using WAF Rules that did not use the 'default' mode but the on/off approach. This fixes that by switching the default value to reset depending in the available values in the `AllowedModes` field.
ghost
added
size/M
kind/documentation
patryk
approved these changes
Dec 5, 2019
|
Thanks @xaf ! |
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing an issue when using WAF Rules that did not use the
'default' mode but the on/off approach. This fixes that by switching
the default value to reset depending in the available values in the
AllowedModesfield.This also returns the
AllowedModeswhen using the WAF rules data source, as theallowed_modesparameter in each item of theruleslist, in order for users to know which modes can be used.