Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the errors when fetching data for the Argo resource #477

Merged

Conversation

XaF
Copy link
Contributor

@XaF XaF commented Sep 25, 2019

The errors were so far only ignored, which let terraform behave
as if everything was fine, even if we were unable to fetch the
current value for the smart routing or tiered caching.

cc @sbfaulkner

The errors were so far only ignored, which let terraform behave
as if everything was fine, even if we were unable to fetch the
current value for the smart routing or tiered caching.
@ghost ghost added the size/XS label Sep 25, 2019
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine by me however there is a caveat that now if someone tries to fetch the smart routing or tiered caching settings and they don't have it enabled (such as a free plan) it will error. Not a blocker just something to be aware of.

@jacobbednarz jacobbednarz merged commit 55d500e into cloudflare:master Sep 27, 2019
@XaF XaF deleted the xaf/fix_argo_read_error_management branch October 2, 2019 15:08
boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants