Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: start using a single put call for teams list update #4737

Merged
merged 3 commits into from
Dec 10, 2024
Merged

feature: start using a single put call for teams list update #4737

merged 3 commits into from
Dec 10, 2024

Conversation

rexscaria
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

changelog detected ✅

@rexscaria rexscaria force-pushed the rex/teams-list-to-use-put-update branch from ffb1990 to f72483d Compare December 9, 2024 19:44
jacobbednarz
jacobbednarz reviewed Dec 10, 2024
View reviewed changes
.changelog/4737.txt Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

acceptance tests all looking good

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTeamsList_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTeamsList_Basic
--- PASS: TestAccCloudflareTeamsList_Basic (8.47s)
=== RUN   TestAccCloudflareTeamsList_BasicWithDescription
--- PASS: TestAccCloudflareTeamsList_BasicWithDescription (6.41s)
=== RUN   TestAccCloudflareTeamsList_LottaListItems
--- PASS: TestAccCloudflareTeamsList_LottaListItems (20.13s)
=== RUN   TestAccCloudflareTeamsList_Reordered
--- PASS: TestAccCloudflareTeamsList_Reordered (4.84s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	41.328s

@jacobbednarz jacobbednarz merged commit 889019a into cloudflare:master Dec 10, 2024
2 checks passed
@github-actions github-actions bot added this to the v4.48.0 milestone Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

This functionality has been released in v4.48.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz jacobbednarz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.48.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rexscaria @jacobbednarz