Fixes destroy on cloudflare_authenticated_origin_pulls #4649
Conversation
|
changelog detected ✅ |
…or nil) in order for the association to be destroyed. Setting this to false keeps the association in a disabled state instead of destroying the resource. Documentation on this API endpoint can be found here: https://developers.cloudflare.com/api/operations/per-hostname-authenticated-origin-pull-enable-or-disable-a-hostname-for-client-authentication Referencing issue raised on provider: cloudflare#4648
PhilipSkinner
force-pushed
the
master
branch
from
b1d6308 to
fa512e3
Compare
|
thanks for the PR. can you please add test coverage for this change to confirm it actually does what we intend here? |
|
will do, this is blocked by the cloudflare API client library not supporting this API endpoint correctly so I'll raise a PR to fix that first then come back to this once its been released |
the API docs state that in order to delete an instance the enabled flag must be set to null. API docs can be found here: https://developers.cloudflare.com/api/operations/per-hostname-authenticated-origin-pull-enable-or-disable-a-hostname-for-client-authentication This fix is required to correct an issue with the cloudflare terraform provider which is currently failing to destroy these resources correctly. This can lead to a hard lock of mtls certificates and origin pulls configured on them as the cloudflare API contains validation bugs on the endpoint documented on the URL above. Issue raised on the terraform provider: cloudflare/terraform-provider-cloudflare#4648 PR raised to fix this on the terraform provider: cloudflare/terraform-provider-cloudflare#4649
the API docs state that in order to delete an instance the enabled flag must be set to null. API docs can be found here: https://developers.cloudflare.com/api/operations/per-hostname-authenticated-origin-pull-enable-or-disable-a-hostname-for-client-authentication This fix is required to correct an issue with the cloudflare terraform provider which is currently failing to destroy these resources correctly. This can lead to a hard lock of mtls certificates and origin pulls configured on them as the cloudflare API contains validation bugs on the endpoint documented on the URL above. Issue raised on the terraform provider: cloudflare/terraform-provider-cloudflare#4648 PR raised to fix this on the terraform provider: cloudflare/terraform-provider-cloudflare#4649
|
PR raised for fixing the API client: cloudflare/cloudflare-go#3680 Once this has been approved and released I'll update the terraform provider to use the fixed library. |
|
Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/changelog-process.md. Example: If you do not require a release note to be included and you have permission, please add the |
|
handled via #4661 |
According to the documentation the enabled flag must be set to null (…or nil) in order for the association to be destroyed. Setting this to false keeps the association in a disabled state instead of destroying the resource.
Documentation on this API endpoint can be found here:
https://developers.cloudflare.com/api/operations/per-hostname-authenticated-origin-pull-enable-or-disable-a-hostname-for-client-authentication
Referencing issue raised on provider:
#4648